Override always default Android hostname verifier#23
Open
Guatom wants to merge 1 commit intonativescript-community:masterfrom
Open
Override always default Android hostname verifier#23Guatom wants to merge 1 commit intonativescript-community:masterfrom
Guatom wants to merge 1 commit intonativescript-community:masterfrom
Conversation
This fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: <root> ; Task: Promise.then ; Value: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified:
Author
|
Hey @roblav96! Any chance for this to get merged? Thanks in advance. |
|
@Guatom You mentioned, that Android requires a SAN value for self-signed certificates. I can't find any information or documentation for this. Do you by any chance have a source for this info? Thanks in advance! |
Author
|
@jjonly sorry my friend! I don't know why I hadn't been notified about this. Do you still need help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following problem:
A couple of months ago, Android stopped accepting self-signed certificates without SAN value when performing a WS call. I took a look at nativescript-https's code and there's this option
validatesDomainName: iffalse, it uses default Android hostname verification which throws the mentioned error; iftrue, it uses a custom hostname verifier.With my proposed change, the custom verifier will always be used, but it will return
trueifvalidatesDomainName === falseand will use current logic ifvalidatesDomainName === true. This can be returned some lines before, just at the beginning ofverifyand save some processing, but I think it looks fancier this way. I'll modify the code if needed.I used this for a development environment and I thought it was useful since I saw some people having the same problem. I think this could be useful for someone else.
Best regards from
_travelDevs.